Fixes #103 Remove width of checkbox from label #148
Conversation
|
@bicknellr PTAL |
| @@ -187,6 +187,7 @@ | |||
| white-space: normal; | |||
| line-height: normal; | |||
| color: var(--paper-checkbox-label-color, var(--primary-text-color)); | |||
| width: calc(100% - var(--paper-checkbox-size) - var(--paper-checkbox-label-spacing)); | |||
There was a problem hiding this comment.
--paper-checkbox-size -> --calculated-paper-checkbox-size
var(--paper-checkbox-label-spacing) -> var(--paper-checkbox-label-spacing, 8px)
There was a problem hiding this comment.
Hmm, slight hiccup here: this change prevents you from using 0 for --paper-checkbox-label-spacing if you're trying to clear the styling so you can use an external label, which I suspect is a relatively common case. Particularly, you can't add lengths (which have units) and unitless values with calc(). Also, you can't multiply two or more values having units, as the result would have units which aren't lengths; so multiplying by 1px or something to get around this is out. :/
There was a problem hiding this comment.
Actually, after reading the CSS values spec, this appears to be a bug in the implementation of calc() that happens to exist in all of Chrome / Firefox / Safari. (I haven't tried out Edge yet.) Filed as https://bugs.chromium.org/p/chromium/issues/detail?id=641556
The label was spilling over by the width of the checkbox and the spacing. This PR removes the spillage.